Skip to content

Fix pyatspi getStateSet compatibility across library versions#713

Merged
Muntasib-creator merged 1 commit into
devfrom
fix-pyatspi-state-set-fallback
Jul 1, 2026
Merged

Fix pyatspi getStateSet compatibility across library versions#713
Muntasib-creator merged 1 commit into
devfrom
fix-pyatspi-state-set-fallback

Conversation

@mahbd

@mahbd mahbd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add fallback to get_state_set() when getStateSet() is unavailable in get_extended_info, since some pyatspi versions use snake_case naming.

Test plan

  • Verify Linux desktop automation state extraction works on environments with older/newer pyatspi versions

@mahbd @claude
Fix pyatspi getStateSet compatibility across library versions
944f312 
Some pyatspi versions expose get_state_set() instead of getStateSet(), causing AttributeError in get_extended_info on Linux desktop automation.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@riz-hossain

riz-hossain commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 1

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 0 suggestions

No actionable issues found in this change; the fallback cleanly improves pyatspi compatibility without introducing a clear correctness regression.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security findings in this PR diff. The change is a compatibility fallback for pyatspi state access and does not introduce new input handling, auth, or exposure risks.

→ Performance Review

Status: ✅ Completed
Suggestions: 0 suggestions

No performance regressions or optimization opportunities were introduced by this compatibility fallback. The change only adds a method-name fallback for pyatspi state retrieval and does not alter query volume, algorithmic complexity, memory use, or network behavior.

→ Testing Review

Status: ✅ Completed
Suggestions: 1 suggestion

The fallback change in get_extended_info() is not covered by a regression test, so the version-compatibility bug could recur unnoticed.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@Zayadul-huq-afnan Zayadul-huq-afnan self-requested a review July 1, 2026 14:43
@Muntasib-creator Muntasib-creator merged commit c920abe into dev Jul 1, 2026
6 checks passed
@Muntasib-creator Muntasib-creator deleted the fix-pyatspi-state-set-fallback branch July 1, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Muntasib-creator Muntasib-creator Muntasib-creator approved these changes
@Zayadul-huq-afnan Zayadul-huq-afnan Zayadul-huq-afnan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahbd @riz-hossain @Muntasib-creator @Zayadul-huq-afnan